Hi Alan,
>
> All shares of a dataset should report the same label and drive letter,
> and I should be able to set sharesmb=off and still have other shares
> report that drive letter and label.
I see what you mean.
> For example:
>
> ? ?zfs create -o casesensitivity=mixed tank/photos
> ? ?zfs sharesmb=off
>
> ? ?sharemgr create -P smb photogroup
> ? ?sharemgr add-share -r public -s tank/photos/public photogroup
> ? ?sharemgr add-share -r private -s tank/photos/private photogroup
>
> I now have two shares (public and private) and sharesmb=off.
>
> If I were to set a label using sharesmb that would cause zfs to share
> tank/photos, which I may not want shared.
I do not understand that. Why wouldn't you just set label with sharemgr than ?
> The current syntax doesn't allow sharesmb=off,label=photos, and if we
> change the syntax of sharesmb it would be inconsistent with sharenfs and
> shareiscsi.
To the contrary - sharenfs does allow such syntax, and it is widely used:
pronto:/home/imp> zfs get sharenfs tank/export/install
NAME PROPERTY VALUE SOURCE
tank/export/install sharenfs ro,anon=0 local
> Suppose I did want to share tank/photos and set some options:
>
> ? ?zfs sharesmb=name=photos,csc=auto,oplocks=disabled,label=z:photos,
>
> Here you would be applying name and csc to the tank/photos share but not
> to the public and private shares, but the oplocks and label values would
> apply to the public and private shares. ?It may cause confusion to mix
> share specific options with dataset wide options in this format.
I do not see how can it causes any confusion. To my understanding it
does exactly what you want, but may be I missing something here.
Anyway, why don't we just always use "final component of the
mountpoint property" as you've suggested and need a special attribute
to override the value ? After all windows users do not have an option
to report volume label other than it is set on the disk.
--
Regards,
Cyril
