Thanks Lubos. I am fine with the networking answer. The only other thing is to put an attributes section in the man page.
I have no other issues. +1 from me. Margot On 03/23/09 11:45, Lubos Kosco wrote: > Margot Miller wrote: > >> Minor issues: >> >> Uncommitted is more consistent with other ARC cases for package name >> >> SUNWopengrok Committed Package name >> >> > > will change ( I registered the name hence I made it committed ;) ) > > >> Attributes section needed in man page. >> >> >> And, could you elaborate more on this from the checklist: >> >> >> 3.4.6 General Security Questions >> (see >> http://opensolaris.org/os/community/arc/bestpractices/security-questions/ >> for details) >> Are there any network protocols used by this project? >> [X] Yes >> [ ] No - continue with the next section (section 3.5) >> >> Do the components use standard network protocols? >> [ ] Yes >> [X] No - ARC review required >> >> > > opengrok web application (the thing you basically see on > http://src.opensolaris.org ) > uses a port listening on localhost only (default conf) which can accept > an object then deserialize it into a configuration object > http://src.opensolaris.org/source/xref/opengrok/trunk/src/org/opensolaris/opengrok/configuration/Configuration.java#362 > - it is used to "refresh" the configuration of web application from > recent indexing without need to restart web container (glassfish or tomcat) > > hence I marked it as non standard protocol, but basically it's a TCP > socket listening for java objects ... > > hope this explains > Lubos > > >> Thanks >> Margot >> >> Margot Miller wrote: >> >> >>> Brian, >>> >>> Please don't close this yet until we get a "+1" from someone. >>> >>> I am reviewing it now. >>> >>> Thanks >>> Margot >>> >>> Brian Utterback wrote: >>> >>> >>>> The timer has expired and I didn't hear any objections, so I am >>>> marking this as closed, approved. >>>> >>>> Brian Utterback wrote: >>>> >>>> >>>>> Okay, any other comments? The timer has expired and I am inclined to >>>>> close this as approved. Anyone? >>>>> >>>>> Lubos Kosco wrote: >>>>> >>>>> >>>>>> On Mar 12, 2009, at 6:37 PM, Darren J Moffat >>>>>> <Darren.Moffat at Sun.COM> wrote: >>>>>> >>>>>> >>>>>> >>>>>>> Brian Utterback wrote: >>>>>>> >>>>>>> >>>>>>>> I am sponsoring the enclosed fast track for Lubos Kosco. The >>>>>>>> timer is set to March 17th. Proposal, checklist and man page are >>>>>>>> enclosed for review. >>>>>>>> This project requires the installation of Exuberent CTags, LSARC >>>>>>>> case >>>>>>>> 2008/741. The man page provided is not actually for a command >>>>>>>> called opengrok. Instead opengrok is intended to be customized >>>>>>>> for each use, so there is an example wrapper script provided in >>>>>>>> /usr/share/doc/opengrok and the man page documents the usage of >>>>>>>> this script. >>>>>>>> >>>>>>>> >>>>>>> Has the swing based GUI gone away and we only have the webapp ? >>>>>>> >>>>>>> >>>>>> Yes. >>>>>> Only webapp and cli search work; GUI wasn't used and no one wanted >>>>>> to maintain it, hence it was dropped. >>>>>> >>>>>> -- >>>>>> L >>>>>> >>>>>> >>>>>> >>>>>>> -- >>>>>>> Darren J Moffat >>>>>>> >>>>>>> >> >> > >
