Joerg Schilling wrote: > "Garrett D'Amore" <gdamore at sun.com> wrote: > >>> What "GNU software" does is basically to follow the documentation for >>> "autoconf". This is: "take this code fragment and copy it into your source". >>> >>> What /usr/include/schily/ and /usr/include/ast do is to put the portability >>> code _once_ into a central location instead. >>> >> Okay. But that isn't what we've been asked to review. What we've been >> asked to review is a couple of utility programs and a supporting >> library. Creating a portability layer and exposing that to the rest of >> ON was not part of the case materials. > > Well, I remember that a similar case (made for ksh93 integration) did already > add such a portability layer although (using the same rules as for star) the > ksh93 case needs those files only for private interfaces. > > The star integration adds more than private interfaces, note that librmt is > supposed to be used by ufsdump/ufsrestore too.....
As far as I can see, this case does not propose changing ufsdump/ufsrestore to use librmt. Such changes would be more suited to a followup case, and should definitely not be snuck in. ... >> No, not really. If you want to create a new portability layer, then >> please propose a new case. This case is about the rmt and star >> application programs, and the supporting librmt. > > This is not a new portability layer. It is in use since more than 15 years. In use in /opt/schily/.... ? Or in use in /usr/include ? It appears to be new *to OpenSolaris* and that is what counts here. >> Going through the case materials further, I'm pretty unhappy about the >> paucity of documentation in librtmt(3). It contains references to >> things like rmtinit(), but no actual documentation -- not even a >> function prototype. This is insufficient information for ARC to >> properly review these APIs, nor for developers to use them. > > If you like to discuss the internals of librmt, I would encourage you to > first > read the man pages... If you can accept a phased integration as several people have already suggested, then we don't need to worry so much about manpages etc and header files for librmt and /usr/include/schily/... James C. McPherson -- Senior Kernel Software Engineer, Solaris Sun Microsystems http://blogs.sun.com/jmcp http://www.jmcp.homeunix.com/blog
