>Gary Winiger wrote: >>> This project proposes changing the maximum value for NGROUPS_MAX >>> from 32 to 1024 by changing the definition of NGROUPS_UMAX from 32 >>> to 1024. >> >>> NGROUPS_MAX as defined by different Unix versions are as follows >>> (http://www.j3e.de/ngroups.html): >>> >>> Linux Kernel >= 2.6.3 65536 >> >> Just a note: a (possibly future) change above INT16_MAX >> will require fixing ON audit code that assumes the >> maximum number of groups is a "short" -- this would need >> to be changed to "ushort". >> >> +1 >> Gary.. > >Is there a reason to not go to 32K right away?
I think that would require quite different algorithms to scale to that point; as there is a push to do a back-port, I prefer to keep the algorithms the same. I'm removing NGROUPS_UMAX for all the userland code so a later change would be simpler in that no work outside the kernel is needed. Casper
