Hi Peter,
Thanks for the feedback, please check my comments inline:
On 02/ 8/10 09:06 PM, Peter Tribble wrote:
> On Mon, Feb 8, 2010 at 2:52 AM, Qing-Ming Jeff Cai
> <qc161282 at sac.sfbay.sun.com> wrote:
> ...
>
>> 2. Project Summary
>> 2.1. Project Description:
>>
>> Libchamplain is a Clutter based map ClutterActor and Gtk+ widget to
>> display
>> street maps, cycle maps or other maps.
>>
> Which version? I don't see that mentioned.
>
The version is 0.43, i will add it into update.
>> libchamplain loads maps from the network using libsoup.
>>
> I notice, however, that libsoup isn't listed in the Interface table.
> Shouldn't it be?
>
Yes, it should be.
> The libchamplain web pages also list Cairo as a dependency. Is it?
>
>
Cairo is a fundamental library, is included in SUNWclutter-gtk as
dependency, so no need mention it here again.
>> Some
>> preconfigured network map sources are built into this library.
>>
> Is there a mechanism to configure the list of sources?
>
>
Map sources are preconfigured in hard code, so no GUI kind of configure
mechanism here.
>> Imported Interfaces Stability Comments
>> -------------------- --------------- -----------------------
>> SUNWgobject-introspection Volatile LSARC/2009/442/
>>
> ...
>
SUNWgobject-introspection being used in compile time to generate GIR
file (An XML format called GIR containing introspection information) ,
so it should not be listed as imported interfaces here.
i will update this.
>> 4.5. Dependencies:
>>
>> SUNWgobject-introspection
>>
> Why is gobject-introspection listed? It's not obvious to me that
> shipping files for its use is any different than shipping .pc files
> for pkgconfig, and that's not listed.
>
>
We do ship .pc files:
/usr/lib/pkgconfig/champlain-0.4.pc Uncommitted
/usr/lib/pkgconfig/champlain-gtk-0.4.pc Uncommitted
BR,
Simon
> Thanks,
>
>
