Stephen,
> Rainer Orth wrote:
> > Files missing from the proto area:
> >
> > T File Name Reloc/Sym name perm owner group
> > inode lnk maj min package(s)
> > ------------------------------------------------------------------------------------------------------------
> > d etc/llc2/default - 755 - -
> > 0 1 - - SUNWllcr
> >
> > SUNWllcr can be built, but this directory is missing. I suppose it is
> > usually created from the closed tree. It is now missing from the closed
> > tarball, so it should probably be added to Targetdirs?
>
> Interesting. This used to be present in previous closed-bins tarballs,
> but seems to be missing in the most recent delivery. I'll try to track
> this down and see why it disappeared.
ok, although I suppose it would be cleaner to just create the directories
via Targetdirs and avoid relying on empty directories in the closed tarball
as far as possible. As I mentioned before, I don't currently understand
which directories are listed in Targetdirs and which are only created by
specific Makefiles.
> > apart from the smartcard stuff (which we might actually ignore since it's
> > on its way out), the main offenders are SUNWonmtst.i (which only lacks
> > usr/bin/mtst, and could perhaps be opened) and SUNWiotu (which lacks
> > usr/sbin/pcitool and the corresponding man page).
>
> Yup. I would ignore smartcard for now since it's slated to be removed
> soon. usr/bin/mtst and usr/sbin/pcitool are explicitly not opened, nor
> included in the closed-binaries tarball...
True, but many other parts from SUNWonmtst are (at least on i386), and Mike
suggested that the fact that those two are currently closed may be due to
the hurry of getting the sources ready for launch.
> > If we need to distinguish between completely closed packages and partially
> > closed packages, we either need to create additional make variables to list
> > them separately and prefix/move only the completely closed ones, or prefix
> > every completely closed package in thosed *_CLOSED_SUBDIRS lists like this:
> >
> > CLOSED_COMMON_XMODS= \
> > SUNWcryptoint \
> > $(CLOSED)/pkgdefs/SUNWsvvs
> >
> > Which solution do you prefer?
>
> I agree, I don't like the idea of duplicating the open exception list...
> that seems like a bad maintenance problem long term. My personal
> preference is to create additional make variables to denote the
> completely-closed packages from the partially-closed packages and move
> the completely closed ones. Mike may have a better opinion though...
After I sent my message, I noticed that e.g. cmd/Makefile uses just the
$(CLOSED)/cmd/ksh etc. form I suggested instead of maintaining additional
lists. I've followed that path and the result is reasonable readable,
certainly more so than adding additional separate lists. Given that
precedent, I'd go for that variant.
I'll probably send Mike my current diffs and new packages for review
shortly, once I get another round of testing in the 20060710 snapshot done.
Rainer
-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University
_______________________________________________
opensolaris-code mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code