[EMAIL PROTECTED] wrote:
AFAIK the only remaining question is whether the following change to the
AT&T source file "builtins.c"
(http://www.nrubsig.org/people/gisburn/work/solaris/ksh93_integration/ksh93_integration_prototype004_webrev_20070210/allfiles/webrev/usr/src/lib/libshell/common/data/builtins.c.html)
requires that we have to put a CDDL license at the top of that file:
Actually, I don't think that's what needs to be asked.
What I suggested asking Bonnie about was whether or not this change
requires a Sun copyright to be added. I don't believe adding a CDDL
block to the ATT code is appropriate but for ON, we typically add a Sun
copyright to files with "significant" change. In my book, significant
includes changes necessary to get the file to actually compile but
others may disagree.
Re: adding a Sun copyright: there are no hard and fast rules. When
working with third-party projects, we should try to adhere to the
culture of that project. And often, copyrights are not added unless the
change is deemed significant in terms of size or complexity. Most of
the people I have talked with in the past have suggested being
conservative in this arena (i.e., only add a Sun copyright for something
truly substantive).
FYI, I think part of the confusion in this discussions stems from
decisions that have previously been made within Sun about adding
copyrights and updating the year in a copyright. To keep things
completely simple wrt to process instructions, 'significant' changes are
defined as changes that result in a change to the object code and
changes to comments that are significant enough to be considered
documentation.
Bottom line - the project members should make a call.
Re: adding the CDDL. As Roland notes, the outbound OSR allows us to
contribute OpenSolaris code to the ksh93 project using the CPL. No need
to put the CDDL on anything.
Sorry for the delay in responding - hope this helps a little.
Bonnie
_______________________________________________
opensolaris-code mailing list
opensolaris-code@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
