On Tue, 2007-08-14 at 10:27 -0700, Artem Kachitchkine wrote:
> > For example, there are two major variants of realtek 8139. The main
> > 8139 family, which is pretty "sucky", and the 8139C+. The 8139C+
> > supports pretty much everything that the 8169 does (including vlan
> > tagging, hardware checksum offload, descriptor based DMA, etc.)
> >
> > The way to tell the difference is to look at a revision register that
> > isn't part of the normal PCI configuration space.
>
> Wouldn't the right solution be to merge two drivers?
No. Sometimes you have to have separate drivers.
For hme/qfe, this is required for backwards compatibility.
For rtl8139/8139C+, the 8139 legacy mode operates *very* differently
from the more modern C+ mode (which is more like an 8169.) Merging
would add a *lot* of complexity and risk to the drivers.
In the case of the 8139C+, it works as is today, its just a degraded
mode compared to what the device *can* do.
-- Garrett
>
> -Artem
> _______________________________________________
> opensolaris-code mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
_______________________________________________
opensolaris-code mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
