Joerg Schilling wrote: > Peter Memishian <[EMAIL PROTECTED]> wrote: > >> Folks, >> >> During the ksh93 code review, the topic of policies for unreferenced files >> in ON came up. As per http://opensolaris.org/os/community/on/findunref >> we've had an internal policy since March 2001 that unreferenced files are >> generally not permitted, but it's not covered in any of the OpenSolaris >> development literature that I'm aware of. As such, I've put together the >> following write-up, which I propose including in the "Best Practices and >> Requirements" section of http://opensolaris.org/os/community/on/devref_toc >> >> 7.5 Unreferenced File Policy >> ============================ >> >> An "unreferenced file" is a file that is not used during a build of a >> given source tree. An unreferenced file is considered a sign of >> brokenness (in much the same manner as an unused variable flagged by >> lint), and thus is forbidden in the ON source tree. However, exceptions >> may be granted by the gatekeepers when appropriate -- usually for: > > If you like to integrate _Portable_ OSS from other sources, you would need > to live with _aparently_ unused files.
I don't see how that follows. In fact including externally maintained upstream source in ON often isn't a good idea at all. If the resync to latest externally maintained source is is basically "download source and build using its built tools" it is probably better off in the SFW consolidation. Note that this policy is ONLY for ON not SFW. Also if the externally maintained source doesn't use any ON private interfaces and doesn't provided anything that ON must have *inside* ON to build (ie the source of this is needed to build ON not the resulting binaries). Then again I'd say that it is very likely better off being built in SFW. Much of the GNU utils software and things like tcsh, zsh etc all fall into this category. Lets take OpenSSL as a real and existing example that is in ON not SFW. There are lots of files in the OpenSSL tar file that I didn't bother to include in ON because they just aren't used. That doesn't actually make resyncing any harder - in fact it actually helps because it is much easier to identify completely new things. So why is OpenSSL in ON and not SFW ? Because it is needed by ON private interfaces in source form (for wanboot). It is modified (for various reasons) and it is built differently (we build both 32 & 64 bit binaries). -- Darren J Moffat _______________________________________________ opensolaris-code mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
