They're related since, for my change to be cstyle clean, a fix to cstyle was required :)
On 09/10/2007, Jonathan Adams <[EMAIL PROTECTED]> wrote: > What's with the cstyle changes? They don't seem to be related to the > bug, nor your other fixes. > > Cheers, > - jonathan > > On 9/17/07, Shawn Walker <[EMAIL PROTECTED]> wrote: > > Greetings, > > > > I've put a webrev containing a proposed fix for bug 4754400 "exrecover > > SEGV's when faced with more than 50 preserved files" here: > > > > http://cr.opensolaris.org/~swalker/4754400/ > > > > It's a small change and I don't think it is the perfect solution, but > > it does fix the problem (at least I believe so and my testing seems to > > play that out). This bug has supposedly been around since at least > > SunOS 3.5, so I reckon it deserves some attention. > > > > Interestingly enough, looking around the web at other versions of this > > file revealed that all of them still have this error (as far as I can > > tell). > > > > I know that: > > 1) it doesn't fix the algorithm by which exrecover determines which > > lucky 50 preserve files are shown (broken imo) > > > > 2) It doesn't fix any lint errors that were already there > > > > 3) It doesn't fix any cstyle errors > > > > At this point, I'm just looking for reviewers to comment on the proposed > > fix. > > > > Thanks, > > -- > > Shawn Walker, Software and Systems Analyst > > [EMAIL PROTECTED] - http://binarycrusader.blogspot.com/ > > > > "Beware of bugs in the above code; I have only proved it correct, not > > tried it. " --Donald Knuth > > _______________________________________________ > > opensolaris-code mailing list > > opensolaris-code@opensolaris.org > > http://mail.opensolaris.org/mailman/listinfo/opensolaris-code > > > -- Shawn Walker, Software and Systems Analyst [EMAIL PROTECTED] - http://binarycrusader.blogspot.com/ "Beware of bugs in the above code; I have only proved it correct, not tried it. " --Donald Knuth _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
