Let me give two examples: usr/src/uts/common/os/swapgeneric.c includes sys/conf.h twice usr/src/uts/common/os/fork.c includes sys/class.h twice
Directly and not conditional, there are many of those double includes around. For me it makes no sense and the second include should be removed. > How have you determined that the redundancy is not > just an artifact of > implementation? For instance, it's not rare for > <a.h> to include <b.h> > internally as an implementation matter -- but if > foo.c needs APIs from > both <a.h> and <b.h>, it should not rely on the > implementation of <a.h>, > but should instead include both <a.h> and <b.h>. This message posted from opensolaris.org _______________________________________________ opensolaris-code mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
