Jason King writes:
> I have an updated webrev http://cr.opensolaris.org/~jbk/ls-2 (in case
> anyone wants to compare to the original version). Hopefully, I've
> addressed all the points, but of course please let me know if I have
> not.
>
> I will send an email to psarc-ext a bit later with the two clarifications.
One small issue in ls.c. At line 486 and 491, there's no guarantee
that scale_len is large enough to allow indexing to scale_len - 1
scale_len - 2. Consider what will happen if the user does:
--block-size=
or:
--block-size=B
(For what it's worth, you could avoid all of the "if (si)" statements
if you had a "kilo" variable conditionally set to 1000 or 1024, and
just did "scale *= kilo".)
Otherwise, your changes and your PSARC message both look good to me.
--
James Carlson, Solaris Networking <[email protected]>
Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
_______________________________________________
opensolaris-code mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
