Joerg Schilling writes:
> I have a re-implementation in my libschily
[...]
>  *    WARNING: a NULL constant is not a NULL pointer, so a caller must
>  *            cast a NULL constant to a pointer: (char *)NULL

How's that?

> strcatl(char *to, ...)

Sigh ... not safe from target overflow problems.  It hasn't learned
the lessons of strcpy(3C) and gets(3C).  I'd recommend at least fixing
that:

   strcatl(char *to, size_t tolen, ...)

but, then, that calls the return value into question.  The return
value probably shouldn't be a pointer to the "last" char if a bounded
output array is supplied because it then becomes impossible for the
caller to detect overflow.

-- 
James Carlson, KISS Network                    <[EMAIL PROTECTED]>
Sun Microsystems / 1 Network Drive         71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677
_______________________________________________
opensolaris-discuss mailing list
opensolaris-discuss@opensolaris.org

Reply via email to