----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/16/#review39 -----------------------------------------------------------
I suppose that there is a problem with the API, as that seems to dictate that the correct way to fix this is to first call setFocusOnAvatar(FALSE, FALSE) to unlock(?) or at least to stop the second call from calling setFocusGlobal, then to call setFocusGlobal and finally calling startCameraAnimation() to start the animation. Or maybe the last call isn't even needed since LLAgentCamera::setFocusGlobal also calls it. I'm not sure, but it would be my guess that calling setFocusOnAvatar(FALSE, FALSE) (in the same place as you do now, before calling setFocusGlobal) is the more correct solution: you don't want to start an animation at this point, you just want to stop focussing on the avatar. Can you try if that works too (Change the last TRUE into a FALSE)? - Aleric On 2010-12-14 07:03:25, Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/16/ > ----------------------------------------------------------- > > (Updated 2010-12-14 07:03:25) > > > Review request for Viewer. > > > Summary > ------- > > You have to push CTRL-\(there is a menu item for this too) twice to get the > last chatter function to work. My fix unlocks the camera before moving it. > > > This addresses bug vwr-20962. > http://jira.secondlife.com/browse/vwr-20962 > > > Diffs > ----- > > indra/newview/llagentcamera.cpp 3d2e71443c58 > > Diff: http://codereview.secondlife.com/r/16/diff > > > Testing > ------- > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
