----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/71/#review120 -----------------------------------------------------------
What about /Me, /ME or /me followed by another punctuation? Ie, "/me?", "/me!", etc... Just asking because these comparisions with just "/me " and "/me'" seem very limited, almost weird. More logical would be to not check anything at ALL - and either expand things, or not. What happens if you just set a flag saying "whatever is in this string, don't expand /me, /who, /whois, /kick etc" without at that point checking for one specific case (missing possibly many other variations). - Aleric On Jan. 5, 2011, 6:14 p.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/71/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2011, 6:14 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > The "/me" in the lsl code below would be displayed rather than being > translated to a name: > llInstantMessage(llGetOwner(),"/me Hello, Avatar!"); > > > This addresses bug STORM-829. > http://jira.secondlife.com/browse/STORM-829 > > > Diffs > ----- > > indra/newview/llviewermessage.cpp 845cab866155 > > Diff: http://codereview.secondlife.com/r/71/diff > > > Testing > ------- > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
