> On Jan. 14, 2011, 1:16 p.m., Boroondas Gupte wrote: > > scripts/install.py, line 598 > > <http://codereview.secondlife.com/r/80/diff/1/?file=388#file388line598> > > > > Does to_install need filtering at all? (Can it contain > > non-installables?)
Reading the docstring of install() , I realized this filtering *is* necessary, or all out-of-date installables would be uninstalled (and only the requested ones re-installed in new versions). I originally was mistaken on what "installables" is. To make the code less misleading, I suggest renaming that function argument to something like "requested_installables". - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/80/#review152 ----------------------------------------------------------- On Jan. 14, 2011, 12:26 p.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/80/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2011, 12:26 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > See https://jira.secondlife.com/browse/VWR-24311 > > Basically, this fixes the TODO comment in install.py but with the difference > that we really want to uninstall any old package with the same name, > different md5 or not. > > > This addresses bug VWR-24311. > http://jira.secondlife.com/browse/VWR-24311 > > > Diffs > ----- > > doc/contributions.txt b0bd26c5638a > scripts/install.py b0bd26c5638a > > Diff: http://codereview.secondlife.com/r/80/diff > > > Testing > ------- > > Loads of testing on linux... Installing new packages now cleanly removes the > old one first. > > > Thanks, > > Aleric > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
