I confess to not liking leaving in incorrectly spelled commented code.
Just saying.
On 17/01/2011 11:31 PM, Oz Linden wrote:
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/87/
indra/llui/llnotifications.cpp
<http://codereview.secondlife.com/r/87/diff/1/?file=407#file407line1384>
(Diff revision 1)
void replaceSubstitutionStrings(LLXMLNodePtr node, StringMap& replacements)
1384
//llwarns<< "replaceSubstituionStrings: value: "<< value<< "
repl: "<< replacement<< llendl;
1384
//llinfos<< "replaceSubstitutionStrings: value:\""<< value<< "\"
repl:\""<< replacement<< "\"."<< llendl;
I don't like leaving in commented-out code.
I would prefer that this either be changed to a debug level message or deleted.
- Oz
On January 14th, 2011, 12:56 p.m., Aleric Inglewood wrote:
Review request for Viewer.
By Aleric Inglewood.
/Updated Jan. 14, 2011, 12:56 p.m./
Description
Fixed a typo that I stumbled upon and added quotes,
and changed the warning to print something that makes
more sense ('replacement' is always empty, since we
didn't find it!)
*Bugs: * VWR-24317 <http://jira.secondlife.com/browse/VWR-24317>
Diffs
* doc/contributions.txt (b0bd26c5638a)
* indra/llui/llnotifications.cpp (b0bd26c5638a)
View Diff <http://codereview.secondlife.com/r/87/diff/>
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
--
Tateru Nino
http://dwellonit.taterunino.net/
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
