> On Jan. 20, 2011, 10:45 a.m., Cron Stardust wrote: > > Looks like you are only preventing the button from drawing and working, but > > not actually /removing/ it from the tray. Have you hunted down the code > > that is used to remove tray buttons when the tray is right-clicked on and > > an item is checked/unchecked? I would think that that is the functionality > > that needs to be copied onto the speak button. > > > > Maybe, as a different JIRA entry and review, you might consider what it > > would take to add the speak button to that tray context menu. Once the > > ability to remove and add the speak button via the context menu is working, > > it would then seem to me that this entry (STORM-236) would be trivial to > > implement, as all the core functionality will have been resolved already. > > Even if the new entry for the context menu wasn't accepted, the core > > functionality can still be done here. > > Wolfpup Lowenhar wrote: > This Issue is for having the button hide(not be drawn) and free up the > space that it normally take in the bottom tray. The problem I'm having is > with the second part getting the space freed up right. Also the context menu > is functional so there are no problems there. > > Cron Stardust wrote: > As of 2.6.0.219259 the Speak button is not able to be removed from the > tray using the context menu. However, the point I was trying to make was > that the underlying functionality of what you are trying to accomplish here, > that of removing a button and freeing up the space, is currently accomplished > by the underlying functionality that the tray context menu taps into. > Whether a simple (hah!) study of that code's functionality will give you what > you need, or whether you do a complementary implementation of adding the > (de)activation of the Speak button to the context menu, is up to you. > > I simply was pointing out that the underlying task is accomplished at > another, potentially missed, location. If you have already studied and > implemented the button (de)activation code that the tray context menu uses, > then my suggestion is just noise. On the other hand, exploring what it would > take to make the Speak button go away or come back via the context menu > allows you to explore another code section that might result in two birds > being killed with one stone: making the button removable for those who only > use the keyboard or mouse toggle, and giving you the code to make the button > go away when Voice isn't active. > > Hope that clears up the situation. To me the problem here isn't the > tasks of "make the button hide" and then "free up the space" - it's about how > to properly remove and re-add the button, similar to how the tray context > menu works, just with a different trigger: the voice setting.
Cron, I wonder if you have even looked at the diff as im working on adding all the functionality that you say is not present. Yes there is some thing im missing other wise I would not be receiving an error in my local repository. this work is only in my local repository at present as it is not yet ready to be posted for review but as Oz suggested i placed this here with the subject "Help Needed" as i believe im missing some thing important in the code and there for getting a error. This is ACTUALLY a request for ASSISTANCE from the open source community and not a review request. - Wolfpup ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/#review210 ----------------------------------------------------------- On Jan. 20, 2011, 9:29 a.m., Wolfpup Lowenhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/112/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2011, 9:29 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is actually a request for for help to debug what I have done so far to > get this working. > 1. In the current diff the button dose actualy hide and show according to if > Voice is enabled or not. > 2. i have two problems at this point. > a. the space taken up by the speak button is not freed up > b. when the speak button is shown after being hidden there is an error > message saying no space avaiable > (I think this is related to the fact that the space is not freed to > begin with). > > > This addresses bug STORM-236. > http://jira.secondlife.com/browse/STORM-236 > > > Diffs > ----- > > doc/contributions.txt 40d0806e9800 > indra/newview/llbottomtray.cpp 40d0806e9800 > indra/newview/llspeakbutton.cpp 40d0806e9800 > indra/newview/skins/default/xui/en/menu_bottomtray.xml 40d0806e9800 > > Diff: http://codereview.secondlife.com/r/112/diff > > > Testing > ------- > > > Thanks, > > Wolfpup > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
