----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review244 -----------------------------------------------------------
As already mentioned in the review request description, comments in message_prehash.h and message_prehash.cpp claim that these files have been generated: indra/llmessage/message_prehash.h <http://codereview.secondlife.com/r/100/#comment181> indra/llmessage/message_prehash.cpp <http://codereview.secondlife.com/r/100/#comment182> Do we have to expect them to be re-generated again in the future? If so, the code for generating them should be changed alongside the change I propose here, so that future generations (pun intended) won't inadvertently override and revert the change. At first, I thought the code for generating them was not part of the source tree, but now I think I have located it in indra/llmessage/message.cpp. (I would have expected it to be a script, not a compiled program.) I will investigate this further and augment the review request with a change to the generating code, too, if applicable. - Boroondas On Jan. 20, 2011, 2:57 p.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/100/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2011, 2:57 p.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > ------- > > For the reason for this change, see > https://jira.secondlife.com/browse/VWR-24487 and > https://jira.secondlife.com/browse/VWR-24522 > > What I did: > In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant > pointers to constants by search/replace. Then I tried to compile and added > const qualifiers in dependent code as needed to stop the compiler complaining. > > Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files > have been generated from the message template. If this generation wasn't a > one-off thing, the generating code must be changed, too, so it won't override > this change here when the generation happens the next time. > > > This addresses bug VWR-24487. > http://jira.secondlife.com/browse/VWR-24487 > > > Diffs > ----- > > doc/contributions.txt fc7e5dcf3059 > indra/llmessage/message_prehash.h fc7e5dcf3059 > indra/llmessage/message_prehash.cpp fc7e5dcf3059 > indra/llprimitive/llprimitive.h fc7e5dcf3059 > indra/llprimitive/llprimitive.cpp fc7e5dcf3059 > indra/llprimitive/llvolumemessage.h fc7e5dcf3059 > indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 > indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 > indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 > > Diff: http://codereview.secondlife.com/r/100/diff > > > Testing > ------- > > Compiled (standalone, 64bit Linux) with and without LL_TESTS. > Started the viewer, logged in, walked and flew around a bit. Everything seems > to work. > > > Locally set _PREHASH_AgentData and _PREHASH_AgentID to (char const*)0x1 in > indra/llui/tests/llurlentry_stub.cpp and > indra/newview/tests/llremoteparcelrequest_test.cpp to verify they actually > are never dereferenced, even when not NULL, so that using NULL pointers > instead of place holder data won't change what code paths gets tested. Both > tests binaries executed without crashes and all the contained tests passed. > > > Thanks, > > Boroondas > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
