Hmm mine added that menu option too :) But if yours fixes STORM-219 and another one too please use yours of course. Just make sure STORM-219 is closed :) /Kip
Subject: Re: Review Request: Added "sort folders by name" option to inventory menu. From: slitovc...@productengine.com To: kip...@hotmail.com; slitovc...@productengine.com; opensource-dev@lists.secondlife.com Date: Mon, 31 Jan 2011 15:43:16 +0000 This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/130/ The code looks good but I've uploaded nearly the same patch a day before: https://codereview.secondlife.com/r/128/. It is related to STORM-316 and includes some other code cleanup needed for that issue. It also adds "sort folders by name" option to inventory menu so perhaps we should go for my patch? - Seth On January 29th, 2011, 1:55 p.m., Kiptic Horsley wrote: Review request for Viewer. By Kiptic Horsley. Updated Jan. 29, 2011, 1:55 p.m. Description The constants SO_FOLDERS_BY_NAME (llinventoryfilter.h line 71) and sort_folders_by_name (llpanelmaininventory.cpp line 125) already existed, so added an option to use them to the inventory menu (menu_inventory_gear_default.xml) and updated llpanelmaininventory.cpp to handle the new option. Bugs: STORM-219 Diffs indra/newview/llpanelmaininventory.cpp (fe7fe04ccc9a) indra/newview/skins/default/xui/en/menu_inventory_gear_default.xml (fe7fe04ccc9a) View Diff
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges