-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/132/
-----------------------------------------------------------
(Updated Feb. 2, 2011, 3:39 p.m.)
Review request for Viewer.
Changes
-------
I redid the patch, hopefully making the comments more acceptable and took out
the use of continue. I moved retrieval of the character positions before the
world positions as I found cases where the information would be incorrect right
near 1024 testing with a couple people below 1024, and a couple people above.
Note this is a replacement patch.
Summary
-------
This modifies the getAvatars function in llworld to also include any avatars
that are found within the range from the LLCharactes list as well (the list of
avatars that is in the viewer object list). This should make sure that anyone
that you visually see within range shows up in the list. Note that changing it
in this function also affects LLFloaterAvatarPicker::populateNearMe,
LLLocalSpeakerMgr::updateSpeakerList, as well as the
LLPanelPeople::updateNearbyList that was originally mentioned in the Jira. The
region avatars lists only contain valid position data when the avatars are
below 1024m. The comment that mentions about retrieving uuids is based on the
function, not the current uses. No current calls in the code are done with the
avatar_ids argument NULL. Duplicates in the returned list need to be
suppressed.
This addresses bug VWR-17050.
http://jira.secondlife.com/browse/VWR-17050
Diffs (updated)
-----
indra/newview/llworld.cpp ebd53632620a
Diff: http://codereview.secondlife.com/r/132/diff
Testing
-------
Simple testing in sandboxes of this patch at 20m and 2000m heights with and
without avatars nearby. Tested with varying the NearMeRange to insure it does
not show avatars beyond the range. Testers need to understand that
RenderFarClip has an impact on the avatars that are actually in the viewer
object list, so setting NearMeRange to a great distance at high altitude won't
necessarily add avatars to the list. Basically if you can see the avatar and
its within NearMeRange, the avatar should be in the nearby avatar list in the
people panel.
Thanks,
Twisted
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
