> On March 26, 2011, 8:55 a.m., Boroondas Gupte wrote: > > indra/newview/llgesturemgr.cpp, lines 536-537 > > <http://codereview.secondlife.com/r/231/diff/1/?file=1327#file1327line536> > > > > If the iterator will not be used outside the loop, please declare it > > with the assignment in the for's braces.
I don't see any reason to make that distinction. - Oz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/231/#review506 ----------------------------------------------------------- On March 25, 2011, 5:33 p.m., Seth ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/231/ > ----------------------------------------------------------- > > (Updated March 25, 2011, 5:33 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > First pass implementation of syncing the animations and sounds before the > gesture starts playing. > The actual playing of animations and sounds of a gesture starts only when all > needed animations and sound files are loaded into viewer cache. This reduces > the delay between animations and sounds meant to be played simultaneously but > may increase the delay between the moment a gesture is triggered and the > moment it starts playing. > > > This addresses bug STORM-380. > http://jira.secondlife.com/browse/STORM-380 > > > Diffs > ----- > > indra/newview/llgesturemgr.h 6c15f820c3b9 > indra/newview/llgesturemgr.cpp 6c15f820c3b9 > > Diff: http://codereview.secondlife.com/r/231/diff > > > Testing > ------- > > > Thanks, > > Seth > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
