-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/276/
-----------------------------------------------------------
Review request for Viewer and Richard Nelson.
Summary
-------
Reason:
When an undocked side tray tab floater got closed with Ctrl+Shift+W,
LLSideTray::setTabDocked() was called. It docked the floater but didn't update
the dock/undock icon.
Fix:
Made setTabDocked() a general purpose method, not a hack suitable for using
only as a floater close callback in the basic viewer mode.
It now updates the dock/undock icon.
Other changes:
* Replaced numerous calls to toggleTabDocked with setDocked(),
that is safer because does exactly what you want.
* Got rid of a duplicated floater close callback.
This addresses bug STORM-1093.
http://jira.secondlife.com/browse/STORM-1093
Diffs
-----
indra/newview/llfloatersidetraytab.cpp UNKNOWN
indra/newview/llsidetray.h UNKNOWN
indra/newview/llsidetray.cpp UNKNOWN
Diff: http://codereview.secondlife.com/r/276/diff
Testing
-------
Testing (un)docking side tray tabs in Basic and Advanced viewer modes.
Thanks,
Vadim
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
