----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/321/ -----------------------------------------------------------
Review request for Viewer. Summary ------- This is mostly a UI change in support of the viewer cache improvements I have been making. The XUI changes were mocked up and approved by Wolf. * Moved viewer cache controls to the advanced tab of the preferences menu. * Changed the cache size control to a spinner. * Relabeled the reset button to "Default Location" to clarify the purpose. * Readded a clear cache button. * Increased the minimum cache size to 64MB and set the max to 9984MB. The increment in the spinner is 64 and both the min, max and default are multiples of 64. Wolf suggested using a high 4 digit number to allow the 4 digit wide spinner text box to suggest the maximum size of the cache. Diffs ----- indra/newview/skins/default/xui/en/panel_preferences_advanced.xml 9c0506d10226 indra/newview/skins/default/xui/en/panel_preferences_setup.xml 9c0506d10226 indra/newview/skins/default/xui/en/notifications.xml 9c0506d10226 indra/newview/llappviewer.cpp 9c0506d10226 indra/newview/llfloaterpreference.h 9c0506d10226 indra/newview/llfloaterpreference.cpp 9c0506d10226 Diff: http://codereview.secondlife.com/r/321/diff Testing ------- I have built and tested all three platforms. I also tried switching between a viewer with a lower max or min. The value in the settings.xml file will be automatically clamped during the cache initialisation. On older viewers, when a user opens the settings tab with the cache size slider, it will jump to within the old bounds. When the user click ok in that preferences menu, the clamped value is saved in the settings file. In the new viewer with the spinner, the old out of bounds value will appear in the spinner until the user changes it. This won't have an effect on the value being used, because of the clamp during init. Thanks, Log
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
