Well... I'm sorry but for me is quite hard remember what i've done yesterday... Got focus about what i've done 1 month ago is impissible...
If i recall correctly i've already used this patch in KV, i can check deeper asap @ home this evening -- Sent by iPhone Il giorno 21/giu/2011, alle ore 12:14, "Boroondas Gupte" < slli...@boroon.dasgupta.ch> ha scritto: This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/ On May 25th, 2011, 2:55 p.m., *Altair Memo* wrote: work fine with both 1.45 from 3p-libs both custom 1.46 prebuilt libs (non-standalone) Have you actually reviewed the code change or just tested the result? - Boroondas On May 25th, 2011, 1:25 p.m., Boroondas Gupte wrote: Review request for Viewer. By Boroondas Gupte. *Updated May 25, 2011, 1:25 p.m.* Description Context: We are currently using Boost 1.45, which already comes with the new Boost Filesystem Library API (Version 3) but still defaults to the old one (Version 2). From Boost 1.46 on, V3 will be the default and Boost 1.47 will be the last one to come with V2. The Boost Filesystem Library documentation recommends "Existing code should be moved to Version 3 as soon as convenient. New code should be written for Version 3. Version 2 is deprecated, and will not be included in Boost releases 1.48 and later." This change overrides the default, so that the V3 API is used, and makes the necessary code changes. (So we can stick to Boost 1.45 and upgrade whenever we feel like it.) Note: I only changed stuff that the compiler complained about. If the new API also changes semantic of still-compiling library usage, more changes might be necessary. Testing * Compiled Viewer (standalone) with Boost 1.45 * Started Viewer * Logged in * Compiled Viewer (standalone) with Boost 1.46 * Started Viewer * Logged in Not tested: * non-standalone *Bugs: * OPEN-67 <http://jira.secondlife.com/browse/OPEN-67> Diffs - doc/contributions.txt (959f9340da92) - indra/llvfs/lldiriterator.cpp (959f9340da92) View Diff <http://codereview.secondlife.com/r/313/diff/>
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges