-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/232/
-----------------------------------------------------------
(Updated July 12, 2011, 11:18 a.m.)
Review request for Viewer.
Summary (updated)
-------
VWR-20801 - Add ability to use SOCKS 5 proxy to the viewer. This allows the UDP
and/or the http requests to be sent via a SOCKS 5 proxy. This also allows http
proxies to be used for other http operations such as caps etc as required. All
the proxy settings have been unified on a single proxy floater accessable from
preferences.
This addresses bug STORM-1112.
http://jira.secondlife.com/browse/STORM-1112
Diffs
-----
indra/llmessage/CMakeLists.txt 65ff7415f171
indra/llmessage/llcurl.cpp 65ff7415f171
indra/llmessage/llpacketring.h 65ff7415f171
indra/llmessage/llpacketring.cpp 65ff7415f171
indra/llmessage/llsocks5.h PRE-CREATION
indra/llmessage/llsocks5.cpp PRE-CREATION
indra/llmessage/net.h 65ff7415f171
indra/llmessage/net.cpp 65ff7415f171
indra/newview/app_settings/settings.xml 65ff7415f171
indra/newview/llfloaterpreference.h 65ff7415f171
indra/newview/llfloaterpreference.cpp 65ff7415f171
indra/newview/llstartup.h 65ff7415f171
indra/newview/llstartup.cpp 65ff7415f171
indra/newview/llviewerfloaterreg.cpp 65ff7415f171
indra/newview/llxmlrpctransaction.cpp 65ff7415f171
indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION
indra/newview/skins/default/xui/en/notifications.xml 65ff7415f171
indra/newview/skins/default/xui/en/panel_preferences_setup.xml 65ff7415f171
Diff: http://codereview.secondlife.com/r/232/diff
Testing
-------
Verified login and in world interaction with proxy disabled, verified login and
in world interactionvia socks 5 proxy. Code has been tested on Windows very
recently and has also worked fine on linux, but i'm not currently in a position
to retest that or Mac at all. Much more testing is needed to verify this does
not break anything unexpectedly and also works as expected when enabled. To
test requires a working socks 5 proxy.
Thanks,
Robin
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges