> On July 16, 2011, 6:48 a.m., Thickbrick Sleaford wrote: > > indra/newview/app_settings/settings.xml, line 4875 > > <http://codereview.secondlife.com/r/399/diff/1/?file=6701#file6701line4875> > > > > Setting the default value to something other than an empty string would > > override the selected grid's login page in LLGridManager::getGridInfo and > > LLGridManager::getLoginPage, which is probably not the desired result. In > > fact, I wonder why this setting is persistent at all. This should probably > > be renamed to CmdLineLoginPage, to be consistent with CmdLineLoginURI etc.
That may be true (have not checked), but this same URL is the login page for all our grids, it doesn't matter. I confirmed that overriding on the command line does work. - Oz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/399/#review883 ----------------------------------------------------------- On July 16, 2011, 6:12 a.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/399/ > ----------------------------------------------------------- > > (Updated July 16, 2011, 6:12 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This changes the URL from which the upper part of the viewer window is loaded > prior to login. > > At the moment, the new URL is internally redirected to the same content as > before, but shortly it will have new community and activity information on > what's going on in Second Life. > > > This addresses bug storm-1510. > http://jira.secondlife.com/browse/storm-1510 > > > Diffs > ----- > > indra/newview/app_settings/settings.xml c6f2f4af65e5 > indra/newview/llviewernetwork.cpp c6f2f4af65e5 > indra/newview/tests/llviewernetwork_test.cpp c6f2f4af65e5 > > Diff: http://codereview.secondlife.com/r/399/diff > > > Testing > ------- > > Confirmed using the log file that the new URL is being requested. > Changed the settings file locally to point to an internal prototype of the > new screen and confirmed that it is displayed correctly. > > > Thanks, > > Oz > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
