-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/427/#review948
-----------------------------------------------------------


Works on windows within the IDE as long as 'package' is enabled (obviously) or 
the credits lists are blank (expected).

- Kadah


On Aug. 2, 2011, 10:40 a.m., Oz Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/427/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2011, 10:40 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> In the Help>About Second Life dialog, there are lists of users who have 
> contributed to the viewer and provided translations.  Prior to this change, 
> those lists had to be updated manually (and had not been updated in quite 
> some time).
> 
> Since we have a separate file (doc/contributions.txt) to track contributions, 
> and it is in an easily parseable format, this change modifies the viewer 
> build to construct a file (app_settings/contributors.txt) containing those 
> names, and another for the translators (app_settings/translators.txt) from a 
> new doc/translations.txt file (the contents of which are not complete in this 
> patch, but are sufficient for review and testing purposes).
> 
> I also removed the list of Lindens from the dialog, as it too had not been 
> updated in a long time and replaced it with a more generic statement.
> 
> 
> This addresses bug storm-1534.
>     http://jira.secondlife.com/browse/storm-1534
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt abd84f85d848 
>   doc/translations.txt PRE-CREATION 
>   indra/newview/llfloaterabout.cpp abd84f85d848 
>   indra/newview/skins/default/xui/en/floater_about.xml abd84f85d848 
>   indra/newview/viewer_manifest.py abd84f85d848 
> 
> Diff: http://codereview.secondlife.com/r/427/diff
> 
> 
> Testing
> -------
> 
> So far built and tested only locally on my Mac... will set up a TeamCity 
> build for other platforms shortly and add a pointer here.  See screenshot on 
> the jira issue.
> 
> 
> Thanks,
> 
> Oz
> 
>

_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Reply via email to