-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/444/
-----------------------------------------------------------
(Updated Aug. 22, 2011, 4:10 a.m.)
Review request for Viewer and Richard Nelson.
Changes
-------
More cleanup and comments, took Oz's feedback into account.
Summary
-------
In busy mode offered inventory items are now moved to trash.
There were two bugs:
1. When auto-discarding inventory offers we looked up missing Busy button
(i.e. a button having index=3) in the inventory offer notification dialog
template. Failure to find the button resulted in ignoring inventory offers.
Fixed that by "auto-clicking" the existing Discard button.
2. It turned out impossible to properly remove an inventory item
from within LLDiscardAgentOffer::done(), because that would lead to
nested LLInventoryModel::notifyObservers() calls.
Fixed that by deferring removal until the next LLAppViewer::idle() iteration.
This addresses bug STORM-1543.
http://jira.secondlife.com/browse/STORM-1543
Diffs (updated)
-----
indra/newview/llappviewer.h 7dbd8eaefaec
indra/newview/llappviewer.cpp 7dbd8eaefaec
indra/newview/llviewermessage.cpp 7dbd8eaefaec
Diff: http://codereview.secondlife.com/r/444/diff
Testing
-------
Thanks,
Vadim
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
