----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/#review993 -----------------------------------------------------------
indra/newview/lltoastnotifypanel.cpp <http://codereview.secondlife.com/r/449/#comment1009> The surrounding code looks quite messy (not your fault, I know), so please make more comments to the code you add. indra/newview/lltoastnotifypanel.cpp <http://codereview.secondlife.com/r/449/#comment1008> I didn't go through the calculations, but the Mute button is visually bigger than the Ignore button. Is it intentional? indra/newview/llviewermessage.cpp <http://codereview.secondlife.com/r/449/#comment1007> It's a hack to update the Block List panel from here. The panel should be an observer of the mute list, or something like that, i.e. update itself automatically. indra/newview/skins/default/xui/en/notifications.xml <http://codereview.secondlife.com/r/449/#comment1006> I suppose these changes must be also made to the "ScriptDialog" notification template. - Vadim On Aug. 23, 2011, 1:41 p.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/449/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2011, 1:41 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Add a block button to popups from llDialog calls. Clicking on the Block > button adds the object to the block list. The type of block is Object. > Changing the object's name does not defeat this block as the block entry is > stored as a UUID. > > Note: The object's name in the block list does not change if the object is > renamed, though the block does work. This may need to be addressed in a > separate SVC jira once this change is incorporated into viewer-development. > > > This addresses bug STORM-1567. > http://jira.secondlife.com/browse/STORM-1567 > > > Diffs > ----- > > doc/contributions.txt 4ebbd04efd93 > indra/newview/lltoastnotifypanel.cpp 4ebbd04efd93 > indra/newview/llviewermessage.cpp 4ebbd04efd93 > indra/newview/skins/default/xui/en/notifications.xml 4ebbd04efd93 > > Diff: http://codereview.secondlife.com/r/449/diff > > > Testing > ------- > > Tested per Test Plan jira entry. > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
