----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/453/#review1004 -----------------------------------------------------------
Ship it! - Seth On Aug. 30, 2011, 4:51 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/453/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2011, 4:51 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Fixed chat bar occupying all available space by default. > > Changes: > - Make sure we initialize desired chat bar width before using it. > - Don't attempt shrinking chat bar by negative amount of pixels > (i.e. effectively extending it). This change may be irrelevant > to the bug I'm fixing, but won't hurt anyway. > - Restored my XML changes that had been lost in merges. > - Minor changes (var names, message text) to improve readability. > - Fixed a typo in comments. > > > This addresses bug STORM-1028. > http://jira.secondlife.com/browse/STORM-1028 > > > Diffs > ----- > > indra/newview/llbottomtray.h 3e6410286eef > indra/newview/llbottomtray.cpp 3e6410286eef > indra/newview/skins/default/xui/en/panel_bottomtray.xml 3e6410286eef > > Diff: http://codereview.secondlife.com/r/453/diff > > > Testing > ------- > > Removed settings, verified that the default chat bar width is 250 px (maybe > too small but that's a separate issue, see JIRA). > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
