-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/461/
-----------------------------------------------------------
Review request for Viewer and Paul ProductEngine.
Summary
-------
Changes:
- Removed a useless (empty) notifyObservers() method.
- Fixed dummy widget creation.
- Removed a redundant getChild() call. We do the same in postBuild(), which is
called earlier.
- Fixing a potential bug: early return from LLGroupMgr::notifyObservers(). Just
noticed it while analyzing code.
- Update role titles in the General tab whenever they change in the Roles tab.
Only the last change is 100% relevant. Please see Bitbucket for more
fine-grained change breakdown.
This addresses bug STORM-918.
http://jira.secondlife.com/browse/STORM-918
Diffs
-----
indra/newview/llgroupmgr.cpp 3e6410286eef
indra/newview/llpanelgroup.h 3e6410286eef
indra/newview/llpanelgroupgeneral.h 3e6410286eef
indra/newview/llpanelgroupgeneral.cpp 3e6410286eef
indra/newview/llpanelgrouplandmoney.cpp 3e6410286eef
indra/newview/llpanelgrouproles.cpp 3e6410286eef
indra/newview/llpanelpeople.cpp 3e6410286eef
Diff: http://codereview.secondlife.com/r/461/diff
Testing
-------
Thanks,
Vadim
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
