----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/463/#review1016 -----------------------------------------------------------
Ship it! Looks good! - Richard On Sept. 7, 2011, 7:49 a.m., Log Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/463/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2011, 7:49 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > The LLProxy code was merged before I could get all the recommended code > review changes implemented, so these changes are all bugfixes to the code > that I changed in https://codereview.secondlife.com/r/374/, which is already > in viewer-development. I also added a simple unit test of the LLSingleton > template to test the functionality that I added. > > > Diffs > ----- > > indra/llcommon/CMakeLists.txt 04642a178228 > indra/llcommon/llsingleton.h 04642a178228 > indra/llcommon/tests/llsingleton_test.cpp PRE-CREATION > indra/llmessage/llcurl.h 04642a178228 > indra/llmessage/llcurl.cpp 04642a178228 > indra/llmessage/llpacketring.h 04642a178228 > indra/llmessage/llpacketring.cpp 04642a178228 > indra/llmessage/llproxy.h 04642a178228 > indra/llmessage/llproxy.cpp 04642a178228 > > Diff: http://codereview.secondlife.com/r/463/diff > > > Testing > ------- > > Builds with this code are available on the project page: > https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer . > > > Thanks, > > Log > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
