----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/473/#review1026 -----------------------------------------------------------
Ship it! great! - Richard On Sept. 14, 2011, 12:20 p.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/473/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2011, 12:20 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Remove the viewer side automatic logout after extended away time. > Note, however, that the server still logs you out after 30 minutes > away: see SVC 7251. > Allow more time (10 seconds vs 2 seconds) after initiating Away status > during which mouse movements do not remove the Away status. > > > This addresses bug storm-1578. > http://jira.secondlife.com/browse/storm-1578 > > > Diffs > ----- > > indra/newview/app_settings/settings.xml ffa9260a0b27 > indra/newview/llagent.h ffa9260a0b27 > indra/newview/llagent.cpp ffa9260a0b27 > indra/newview/llappviewer.cpp ffa9260a0b27 > indra/newview/llviewerjoystick.cpp ffa9260a0b27 > indra/newview/llviewerwindow.cpp ffa9260a0b27 > > Diff: http://codereview.secondlife.com/r/473/diff > > > Testing > ------- > > I've done local testing with these changes. > > For some reason I can't figure out, adding just these changes to the > then-current viewer-development tip increased the likelihood (to something > very close to 100%) of crashing due to problems with multi-threaded curl use. > There is a separate proposed fix for that (see STORM-1562), and integrating > that proposed fix eliminated the problem and allowed me to test these changes. > > > Thanks, > > Oz > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
