----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/478/#review1031 -----------------------------------------------------------
Ship it! seems reasonable - Richard On Sept. 16, 2011, 9:14 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/478/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2011, 9:14 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > ------- > > Folder view stole "Delete" key presses from the line editor when renaming a > newly created inventory item. > > Reason: > LLFocusMgr::setKeyboardFocus() which is called from LLLineEditor::setFocus() > makes the folder view the edit menu handler, thus it receives the Delete key > presses instead of the line editor. > > Fix: > Make sure the line editor becomes the edit menu handler whenever it's focused, > no matter is it a child of a folder view or not. > > > This addresses bug STORM-1600. > http://jira.secondlife.com/browse/STORM-1600 > > > Diffs > ----- > > indra/llui/lllineeditor.cpp 656d988266e8 > > Diff: http://codereview.secondlife.com/r/478/diff > > > Testing > ------- > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
