> On Nov. 18, 2011, 6:06 a.m., Lance Corrimal wrote: > > Built it into dolphin 3.2 beta, tested it. found a few issues: > > - main menu option Build/Upload/Script does nothing at all > > - saving a script that you open from your inventory to disk only works > > after you edit the script > > - saving a script to disk does not add .lsl to the filename by default > >
Thanks for the feedback. - The Build => Upload => Script entry shouldn't be there, I'll correct the code. It's a follow up project, which I haven't completed yet. - Saving only works after editing. This is normal behaviour for scripts, I was doubtful of doing it this way, but did so to maintain consistency. If there is a consensus to alter this behaviour I would happily agree to do so. - Hmm, .lsl should be added by default, I'll look into this. - Ima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1076 ----------------------------------------------------------- On Nov. 17, 2011, 3:08 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2011, 3:08 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Changes to allow opened script window to save/load to/from files on the users > computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/llviewermenufile.cpp a1319d553db9 > indra/newview/skins/default/xui/en/menu_viewer.xml a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
