----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/520/#review1090 -----------------------------------------------------------
Quick comment regarding behavior...we really should not play any audio during the teleport blackout as it is disconcerting to feel like you are still in an area (hearing the audio) but not be able to see or interact with anything. Everything else sounds great. - Richard On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/520/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2011, 5:59 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Audio fading in has been added for when a music stream starts. Audio fading > out has been added for when there is a change in the music stream that is > playing. > > Two dead files have been eliminated. > > An existing bug in how music was not being paused correctly has been fixed. > > When you are teleporting you will hear the music stream from the place you > are leaving. This is a change in behavior; previously the music stream was > stopped when the teleport progress bar was being displayed. > > This code change affects several areas where music is started or stopped. > The new code has evolved significantly, so please look for things that might > not "make sense." > > > This addresses bug STORM-591. > http://jira.secondlife.com/browse/STORM-591 > > > Diffs > ----- > > doc/contributions.txt 8b455c1b7a5e > indra/newview/lloverlaybar.h 8b455c1b7a5e > indra/newview/lloverlaybar.cpp 8b455c1b7a5e > indra/newview/llpanelnearbymedia.h 8b455c1b7a5e > indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e > indra/newview/llvieweraudio.h 8b455c1b7a5e > indra/newview/llvieweraudio.cpp 8b455c1b7a5e > indra/newview/llviewermedia.cpp 8b455c1b7a5e > indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e > > Diff: http://codereview.secondlife.com/r/520/diff > > > Testing > ------- > > See the massive test plan in the jira. > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
