----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1133 -----------------------------------------------------------
indra/newview/llpreviewscript.cpp <http://codereview.secondlife.com/r/516/#comment1100> Why not take the '!' off that test, and put the following code inside the 'then' block - then you don't need an early and deeply nested return indra/newview/llpreviewscript.cpp <http://codereview.secondlife.com/r/516/#comment1101> Use braces per coding standard, or even better, just use a conditional expression in the return statement: return (self && self->mEditor) ? self->mEditor->canLoadOrSaveToFile() : FALSE; - Oz Linden On Dec. 25, 2011, 3:17 p.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2011, 3:17 p.m.) > > > Review request for Viewer. > > > Description > ------- > > Changes to allow opened script window to save/load to/from files on the users > computer. > > > This addresses bug storm-1708. > http://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/llui/lltexteditor.h a1319d553db9 > indra/llui/lltexteditor.cpp a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > indra/newview/skins/default/xui/en/strings.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima Mechanique > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
