----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/530/#review1134 -----------------------------------------------------------
works for me, but unless the default log level is set to something less verbose than "INFO" this is nice to have but almost useless... alternatively, the selected log level could be saved in settings. - Lance Corrimal On Dec. 23, 2011, 9:15 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/530/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2011, 9:15 a.m.) > > > Review request for Viewer. > > > Description > ------- > > Provide a 1) login screen Debug and 2) Develop sub-menu to change the default > logging level > > > This addresses bug STORM-1790. > http://jira.secondlife.com/browse/STORM-1790 > > > Diffs > ----- > > doc/contributions.txt 3a521e980fbf > indra/llcommon/llerror.cpp 3a521e980fbf > indra/llcommon/llerrorcontrol.h 3a521e980fbf > indra/newview/llviewermenu.cpp 3a521e980fbf > indra/newview/skins/default/xui/en/menu_login.xml 3a521e980fbf > indra/newview/skins/default/xui/en/menu_viewer.xml 3a521e980fbf > > Diff: http://codereview.secondlife.com/r/530/diff/diff > > > Testing > ------- > > Opened debug log on screen and adjusted setting via the menu. Noted that > logging adjusted to what the level was set to, at least for Debug (which also > is All), Info, Warning, and None. I did not test Error, which probably is a > bit of a moot point, as it is supposed to cause a crash. > > > Thanks, > > Jonathan Yap > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
