----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/596/ -----------------------------------------------------------
(Updated Sept. 13, 2012, 8:38 a.m.) Review request for Viewer. Changes ------- Fix: The current selection needs to be deselected before I can move the cursor to it's new position. Description ------- Repository is here: https://bitbucket.org/MartinRJ/bug-59 I more or less cloned the search-function and modified the floater via xml (new file: floater_goto_line.xml) to fit for a 'go to line' floater. Also I added a callback to prevalidate the input in the 'go to line' line-editor, so that only numbers can be entered into it. This addresses bug BUG-59. https://jira.secondlife.com/browse/BUG-59 Diffs (updated) ----- doc/contributions.txt 7a056d7afeb2 indra/newview/llpreviewscript.h 7a056d7afeb2 indra/newview/llpreviewscript.cpp 7a056d7afeb2 indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 Diff: http://codereview.secondlife.com/r/596/diff/ Testing ------- Tested on my local PC with a modded "3.3.4-release3" version. Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go to line', enter a number less than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0). Repeat the test with a script inside an object's content. Thanks, MartinRJ Fayray
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
