-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/608/
-----------------------------------------------------------
Review request for Viewer.
Description
-------
Simply had to guard the snapping code, making sure that the last "else" case
was preserved when either the outer or the inner tests failed.
Careful analysis and testing was performed to determine what clauses
could/should be inside the guarding if statement, which led to the discovery
that the else clause had to be preserved outside under a separate test. Code
structure was carefully designed to match the other llManip* classes in similar
areas.
This addresses bug STORM-1919.
https://jira.secondlife.com/browse/STORM-1919
Diffs
-----
doc/contributions.txt 9505109727a3e948b11564910fd58ee93503b3df
indra/newview/llmaniprotate.cpp 9505109727a3e948b11564910fd58ee93503b3df
Diff: http://codereview.secondlife.com/r/608/diff/
Testing
-------
Tested all rotation cases (edge-on & facing multiplied with snapping enabled &
disabled) in Firestorm - however this area of code has not been modified in
either viewer since ancient times and should therefore cause no ill effects.
Thanks,
Cron Stardust
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
