----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/609/#review1278 -----------------------------------------------------------
Kokua's approach was to updated the libs and deliver them using viewer_manifest.py. Using the updated libs/includes I get the following compiler error. It appears when the libs are LL updated this mod will need to be backed out. ‘static std::vector<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator<char> > > > LLWindowSDL::getDynamicFallbackFontList()’: /home/bill/kokua-dev-q/indra/llwindow/llwindowsdl.cpp:2651: error: cannot convert ‘FcResult’ to ‘FcResult*’ for argument ‘5’ to ‘FcFontSet* FcFontSort(FcConfig*, FcPattern*, FcBool, FcCharSet**, FcResult*)’ - Nicky Perian On Nov. 30, 2012, 5:17 p.m., Log Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/609/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2012, 5:17 p.m.) > > > Review request for Viewer. > > > Description > ------- > > This is a fix for STORM-1854. It prevents an assert failure that happens > during viewer startup on linux systems with a sufficiently new version of the > fontconfig library (I think fontconfig 1.9). It should not impact mac or > windows because those platforms do not use llwindowsdl.cpp file, which was > the only file changed. > > > This addresses bug STORM-1854. > http://jira.secondlife.com/browse/STORM-1854 > > > Diffs > ----- > > indra/llwindow/llwindowsdl.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/609/diff/ > > > Testing > ------- > > This change builds successfully on all three platforms (Teamcity). I have > verified that the startup error no longer occurs on Ubuntu 12.10. Ideally we > would test that Linux systems with older versions of fontconfig can also > still start the viewer, but I don't have easy access to one of those. > > > Thanks, > > Log Linden > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
