https://bugzilla.mindrot.org/show_bug.cgi?id=983
--- Comment #44 from David Woodhouse <dw...@infradead.org> 2011-09-27 07:22:44 EST --- (In reply to comment #33) Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7ffff7f3f7e0 (LWP 3257)] 0x00007ffff7f9c32a in input_userauth_info_response (type=<optimized out>, seq=<optimized out>, ctxt=0x7ffff8213b90) at auth2-chall.c:344 344 userauth_finish(authctxt, authenticated, "keyboard-interactive", (gdb) p kbdintctxt->device->name Cannot access memory at address 0x0 (gdb) p kbdintctxt->device $7 = (KbdintDevice *) 0x0 I don't quite understand how the extra 'submethod' argument to userauth_finish() and auth_log() are relevant to this patch. Normally I would expect them to be part of a separate patch. It appears to be entirely cosmetic... part from the SEGV that it causes. So I fixed it thus without worrying too much about what it *should* have been: --- auth2-chall.c~ 2011-09-26 20:50:00.741593219 +0100 +++ auth2-chall.c 2011-09-26 22:18:41.119608430 +0100 @@ -342,7 +342,7 @@ input_userauth_info_response(int type, u } } userauth_finish(authctxt, authenticated, "keyboard-interactive", - kbdintctxt->device->name); + kbdintctxt->device?kbdintctxt->device->name:NULL); } void Note: This SEGV wasn't trivial to find. The symptom was just that mm_request_receive() got -EPIPE after the child process died. No hint about the SEGV was visible because a handler was installed. Even when running it in gdb it didn't show up until I set 'follow-fork-mode child'. Is this not a really bad thing? -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug. You are watching the reporter of the bug. _______________________________________________ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs