The branch OpenSSL_1_0_2-stable has been updated
       via  6f997dc36504d67d1339ceb6bce4ecba673d8568 (commit)
      from  21b538d616b388fa0ce64ef54da3504253895cf8 (commit)


- Log -----------------------------------------------------------------
commit 6f997dc36504d67d1339ceb6bce4ecba673d8568
Author: Ismo Puustinen <ismo.puusti...@intel.com>
Date:   Fri Sep 18 16:07:23 2015 -0400

    GH367: use random data if seed too short.
    
    Signed-off-by: Rich Salz <rs...@openssl.org>
    Reviewed-by: Emilia Käsper <emi...@openssl.org>

-----------------------------------------------------------------------

Summary of changes:
 crypto/dsa/dsa_gen.c                   | 2 +-
 doc/crypto/DSA_generate_parameters.pod | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/dsa/dsa_gen.c b/crypto/dsa/dsa_gen.c
index 5a328aa..9d3b59e 100644
--- a/crypto/dsa/dsa_gen.c
+++ b/crypto/dsa/dsa_gen.c
@@ -203,7 +203,7 @@ int dsa_builtin_paramgen(DSA *ret, size_t bits, size_t 
qbits,
             if (!BN_GENCB_call(cb, 0, m++))
                 goto err;
 
-            if (!seed_len) {
+            if (!seed_len || !seed_in) {
                 if (RAND_pseudo_bytes(seed, qsize) < 0)
                     goto err;
                 seed_is_random = 1;
diff --git a/doc/crypto/DSA_generate_parameters.pod 
b/doc/crypto/DSA_generate_parameters.pod
index 16a67f2..b1a4d20 100644
--- a/doc/crypto/DSA_generate_parameters.pod
+++ b/doc/crypto/DSA_generate_parameters.pod
@@ -29,7 +29,7 @@ maximum of 1024 bits.
 If B<seed> is B<NULL> or B<seed_len> E<lt> 20, the primes will be
 generated at random. Otherwise, the seed is used to generate
 them. If the given seed does not yield a prime q, a new random
-seed is chosen and placed at B<seed>.
+seed is chosen.
 
 DSA_generate_parameters_ex() places the iteration count in
 *B<counter_ret> and a counter used for finding a generator in
_____
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits

Reply via email to