Sebastian Akerman wrote:
>
> Dr Stephen Henson wrote:
>
> > I've had a quick look at this and some things in this are more than a
> > bit naughty. Having the same OID with multiple NIDs is one. The SHA1
> > change to use NID_rsaEncryption is another.
> >
> > Both could have nasty repercussions which would break other code.
> >
> > Steve.
>
> I backtracked a bit and removed the OID and NID stuff from objects.h.
> It works alright anyway. I guess that the set_asn1_parameter removed
> the lookup problem (which I fixed with the OIDs before doing the
> set_asn1_parameter stuff).
>
> I did not remove the NID and SN defines for RC2_40, however (not
> my contribution). I don't need them and the tests pass w/o them.
>
> New patches follow. Sorry for all the xtra hazzle with my "naughty" and
> "drastic" changes. I plan to look into some other pkcs9 things like
> SMIME-Capabilities e.g., whenever time permits.
>
I've worked in a patch based on your stuff which should fix the code but
without anything "naughty", it's in the latest snapshot. Let me know of
any problems.
I've done some S/MIME capabilities stuff myself but haven't got round to
incorporating it into the core source. It'll have to wait until after
things get unfrozen after 0.9.3 release. We also need an application
that can call all of this stuff when its working.
Steve.
--
Dr Stephen N. Henson. http://www.drh-consultancy.demon.co.uk/
Personal Email: [EMAIL PROTECTED]
Senior crypto engineer, Celo Communications: http://www.celocom.com/
Core developer of the OpenSSL project: http://www.openssl.org/
Business Email: [EMAIL PROTECTED] PGP key: via homepage.
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [EMAIL PROTECTED]
Automated List Manager [EMAIL PROTECTED]
