Mark Crispin <[EMAIL PROTECTED]>:

> The -p switch to mkdir is used frequently in the makefiles.  This is
> not portable; traditional mkdir doesn't offer any switches at all.
> The upshot is that a -p directory is created in the openssl source
> directory.  Better not to rely upon -p, and create the parent
> directories by hand as necessary.

Ok.

> The nextstep port uses the -O3 switch to gcc.  Support for -O3 didn't appear
> until later (and buggier) versions of NeXTstep.  Use -O instead, or have a
> separate port.

Ok.

> e_os.h and several other files include <unistd.h>.  This is not
> portable; unistd.h is a SysVism

It's not; it's POSIX (and hence portable by definition :-).

>                                 that was not in traditional UNIX or
> traditional BSD.  On traditional systems, use <libc.h>.  I kludged
> up a dummy unistd.h that is an include of libc.h.

We could do something of this kind automatically if no unistd.h exists
(or set a link to /usr/include/libc.h in the source code include/
directory if the real unistd.h is not found).

> s_server.c references unknown symbols _S_IFMT and _S_IFDIR.  I changed it to:
>       #ifndef S_ISDIR
>       #if defined(VMS) && !defined(__DECC)
>       #define S_ISDIR(a)      (((a) & S_IFMT) == S_IFDIR)
>       #elif defined(NeXT)
>       #define S_ISDIR(a)      (((a) & S_IFMT) == S_IFDIR)
>       #else
>       #define S_ISDIR(a)      (((a) & _S_IFMT) == _S_IFDIR)
>       #endif
>       #endif
> but I suspect that a more general fix is needed.

#ifndef S_ISDIR
# if defined(_S_IFMT) && defined(_S_IFDIR)
#  define S_ISDIR(a)    (((a) & _S_IFMT) == _S_IFDIR)
# else
#  define S_ISDIR(a)    (((a) & S_IFMT) == S_IFDIR)
# endif
#endif

should work everywhere where it can be done at all.
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to