Re: cvs commit: openssl/crypto/bn bn.h bn_exp.c bn_exp2.c bn_gcd.cbn_lib.c bn_mont.c bn_mul.c bn_prime.c bn_recp.c bn_shift.c bn_sqr.cbntest.c

[Richard Levitte - VMS Whacker]

From: Ulf Moeller <[EMAIL PROTECTED]>

ulf> > What impact does that have on the performance?
ulf> 
ulf> openssl speed is 15% slower for 1024 bit RSA signatures.  That is
ulf> totally unacceptable (except for the DEBUG version); I hope we don't
ulf> have to have an argument about that.

I'm starting to think that we should have BN_mul() and BN_sqr() break
constness when they need to do a bn_wexpand().  After all, there are
flags telling us if the BIGNUM is static or not, and if it isn't, it's
been allocated on the heap.

If that seems like an OK solution, I'll restore BN_mul() and BN_sqr()
to use bn_wexpand() instead of bn_dup_expand().  I'll still let
bn_dup_expand() stick around since it may be useful in the future.

Comments?

-- 
Richard Levitte   \ Spannv�gen 38, II \ [EMAIL PROTECTED]
Chairman@Stacken   \ S-168 35  BROMMA  \ T: +46-8-26 52 47
Redakteur@Stacken   \      SWEDEN       \ or +46-709-50 36 10
Procurator Odiosus Ex Infernis                -- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/
Software Engineer, Celo Communications: http://www.celocom.com/

Unsolicited commercial email is subject to an archival fee of $400.
See <http://www.stacken.kth.se/~levitte/mail/> for more info.
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]