Re: cvs commit: openssl/crypto/bn bn.h bn_exp.c bn_exp2.cbn_gcd.cbn_lib.c bn_mont.c bn_mul.c bn_prime.c bn_recp.c bn_shift.cbn_sqr.cbntest.c

[Richard Levitte - VMS Whacker]

From: Ben Laurie <[EMAIL PROTECTED]>

ben> > I'm starting to think that we should have BN_mul() and BN_sqr() break
ben> > constness when they need to do a bn_wexpand().  After all, there are
ben> > flags telling us if the BIGNUM is static or not, and if it isn't, it's
ben> > been allocated on the heap.
ben> 
ben> Doesn't this mean you'll have to undo loads of constification? I do hope
ben> you don't mean that you'll cast away the const?

It does mean exactly that.  If we want to constify the API, what
choice do we have?  Also, note that in the problematic sections,
there's a check to see that the BIGNUM data isn't flagged as static.

This *is* a conflict between the wish to constify and efficiency.  If
you have some elegant solution, please tell us.

-- 
Richard Levitte   \ Spannv�gen 38, II \ [EMAIL PROTECTED]
Chairman@Stacken   \ S-168 35  BROMMA  \ T: +46-8-26 52 47
Redakteur@Stacken   \      SWEDEN       \ or +46-709-50 36 10
Procurator Odiosus Ex Infernis                -- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/
Software Engineer, Celo Communications: http://www.celocom.com/

Unsolicited commercial email is subject to an archival fee of $400.
See <http://www.stacken.kth.se/~levitte/mail/> for more info.
______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       [EMAIL PROTECTED]
Automated List Manager                           [EMAIL PROTECTED]