On Wed, 2 Jan 2002, Richard Levitte - VMS Whacker wrote:
> I've looked at your patch, and it looks rather sane with only one
> glaring exception: in Configure, you have some code that does all the
> copying of *test.c and the exported include files, and I wonder why
> not let 'make links' take care of that in the normal fashion?
The reason I wrote this is that "make links" doesn't take care of
this. The code in the patch only copies or links the test and header
files for algorithms that are excluded by Configure. The Makefiles in
the directories of excluded algorithms are never run, so the test and
header files are not linked when "make links" is run. The link section
of Makefile reads "for i in $(DIRS)", but the directories of excluded
algorithms have already been removed from $(DIRS) by the Configure
script. I usually run with no-idea and no-rc5. You probably don't see
the problem since the tarball has symbolic links for these already
included. The DOS untar utilities can't use these and creates 0 byte
files instead. Make links corrects this, overwriting the 0 byte files
for the algorithms used, but leaving 0 byte files for the others. If
your tar utility recognizes symbolic links, you have the files when
you untar, with make links redoing this for the included algorithms.
> The only other thing I noticed is that you probably have forgotten a
> '../' in the patch of crypto/des/Makefile.ssl.
Yes, this is not portable. I put the correct fix in the patch for the
0.9.7 branch. When you make symbolic links you need the "../", but it
doesn't work when copying. This fix, which should work whether
making links or copying, uses the absolute rather than relative path.
This is from my patch for the 0.9.7 branch:
--- openssl-0.9.7/crypto/des/Makefile.ssl.orig Thu Dec 20 14:25:26 2001
+++ openssl-0.9.7/crypto/des/Makefile.ssl Sat Dec 22 17:24:04 2001
@@ -107,7 +107,7 @@
links:
@$(TOP)/util/point.sh Makefile.ssl Makefile
- @$(TOP)/util/point.sh ../../perlasm asm/perlasm
+ @$(TOP)/util/point.sh `cd ../perlasm;pwd` asm/perlasm
@$(PERL) $(TOP)/util/mklink.pl ../../include/openssl $(EXHEADER)
@$(PERL) $(TOP)/util/mklink.pl ../../test $(TEST)
@$(PERL) $(TOP)/util/mklink.pl ../../apps $(APPS)
Sorry I missed this when correcting the 0.9.6c patch. I noticed it was
wrong while working on 0.9.7.
Doug
__
Doug Kaufman
Internet: [EMAIL PROTECTED]
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [EMAIL PROTECTED]
Automated List Manager [EMAIL PROTECTED]
