In message <[EMAIL PROTECTED]> on Wed, 08 May 2002 17:31:41
-0600, "Verdon Walker" <[EMAIL PROTECTED]> said:
VWalker> This patch fixes the routine BIO_vprintf in
VWalker> crypto\bio\b_print.c so that no longer allocates a 10k buffer
VWalker> on the stack that is never really used.
I just looked at the code, and I have a hard time seeing why the
stack-allocated buffer would never be used. Please note that any heap
allocation will be made only when *currlen gets larger than or equal
to *maxlen. When the static buffer is passed, it's size (10240) is
also passed, so allocation of the dynamic buffer will only happen when
that functionality is desired (by passing the appropriate pointer) and
the calling function is about to overflow the static buffer.
At least, this is what I can conclude by looking at the code. If
you're of a different opinion on how it works, please show me.
I entirely agree with the move of the assert() in doapr_outch(), and
will apply that part immediately. I'll think about the rest.
--
Richard Levitte \ Spannvägen 38, II \ [EMAIL PROTECTED]
Redakteur@Stacken \ S-168 35 BROMMA \ T: +46-8-26 52 47
\ SWEDEN \ or +46-708-26 53 44
Procurator Odiosus Ex Infernis -- [EMAIL PROTECTED]
Member of the OpenSSL development team: http://www.openssl.org/
Unsolicited commercial email is subject to an archival fee of $400.
See <http://www.stacken.kth.se/~levitte/mail/> for more info.
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [EMAIL PROTECTED]
Automated List Manager [EMAIL PROTECTED]
